Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #181

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Update dependencies #181

wants to merge 3 commits into from

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented May 4, 2024 •
edited
Loading

  • Use default-features = false more to reduce deps & compile time
  • Sort dependency list
  • Add config for cargo-all-features which allows testing all combinations
  • Use SPDX syntax to specify the licenses are ORd together.
  • Increase MSRV to fix clippy error

Here is the reason for MSRV being bumped

warning: current MSRV (Minimum Supported Rust Version) is `1.56.0` but this item is stable since `1.63.0`
 --> fake/src/impls/std/array.rs:9:9
  |
9 |         std::array::from_fn(|_| Fake::fake_with_rng::<T, _>(config, rng))
  |         ^^^^^^^^^^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
  = note: `#[warn(clippy::incompatible_msrv)]` on by default

jayvdb
jayvdb commented May 4, 2024
View reviewed changes
fake/src/impls/color/mod.rs
@@ -10,6 +10,7 @@ impl Dummy<Faker> for RandomColor {
luminosity: Some(Luminosity::Random),
seed: Some((u64::MIN..u64::MAX).fake_with_rng::<u64, _>(rng)),
alpha: Some((0..10).fake_with_rng::<i8, _>(rng) as f32 / 10.),
..Default::default()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is needed for random_color v0.8

jayvdb
jayvdb commented May 4, 2024
View reviewed changes
fake/Cargo.toml
Comment on lines +81 to +82
[package.metadata.cargo-all-features]
denylist = ["geo-types", "serde_json"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can also be solved by adding these to [features] so their other co-dependencies can be specified

@jayvdb jayvdb force-pushed the strip-dep-features branch from 2f2af07 to ec694be Compare May 4, 2024 04:51
@jayvdb
Copy link
Contributor Author

jayvdb commented May 5, 2024

IMO there is too much happening here. I am going to break it into smaller PRs.

@jayvdb jayvdb marked this pull request as draft May 5, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jayvdb